[Payment due @ahmedGaber93] Docs updates for E/A#94511 attendee columns sortable in report view#95295
[Payment due @ahmedGaber93] Docs updates for E/A#94511 attendee columns sortable in report view#95295MelvinBot wants to merge 1 commit into
Conversation
…view Co-authored-by: ahmedGaber93 <ahmedGaber93@users.noreply.github.com>
|
@MelvinBot mark this PR Ready for review. |
|
🤖 Done — this PR is now marked Ready for review. |
| @@ -46,6 +46,8 @@ When any expense in a report has attendees, the report shows two additional colu | |||
| - **Attendees:** displays the attendees added to each expense. | |||
| - **Per attendee:** shows the total amount divided equally among all attendees. | |||
|
|
|||
There was a problem hiding this comment.
UI label consistency: For the column-selection action, this article elsewhere uses the exact label Per attendee amount (see the search-results steps: "Select Attendees and Per attendee amount"). Here the selection references Per attendee, which shortens the label. Per HELPSITE_NAMING_CONVENTIONS.md (use exact UI text, do not shorten labels), update "select Attendees and Per attendee" to "select Attendees and Per attendee amount". The column header is correctly Per attendee.
|
IyMgSGVscERvdCBEb2N1bWVudGF0aW9uIFJldmlldw== |
ahmedGaber93
left a comment
There was a problem hiding this comment.
LGTM!
In #94124, we display those columns on the report page, so documenting those steps to explain how to display them on the report page looks good.
|
🎯 @ahmedGaber93, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
HelpDot Documentation Review Overall Assessment This is a small, well-scoped documentation follow-up to #94511. It adds one paragraph under the existing How to view attendees on a report section explaining that the Attendees and Per attendee columns can be shown in a report and clicked to sort the report's expenses, and broadens the article Scores Summary
Key Findings
Recommendations
Files Reviewed
Overall recommendation: Approve (address the minor Per attendee vs Per attendee amount label consistency as a nice-to-have). Note: Detailed line-by-line feedback has been provided as inline comments. |
Explanation of Change
Docs follow-up for #94511, which makes the Attendees and Per attendee columns sortable in the single expense report view (previously they were only sortable in Search / Reports > Expenses).
The help article Adding Attendees previously described sorting by these columns only in search results. This PR updates the How to view attendees on a report section to note that, once the Attendees and Per attendee columns are shown in a report, you can click either column header to sort the report's expenses by that column. The article
descriptionwas also broadened to mention sorting in a report as well as in search results.Related PR
Fixed Issues
N/A — documentation-only follow-up.
@ahmedGaber93, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.